Skip to content

Conversation

zsistla
Copy link
Contributor

@zsistla zsistla commented Sep 10, 2024

actions/[email protected] includes a breaking change of that causes hidden directories and files not being uploaded. Since code coverage artifacts are in agent/.libs directory, this functionality needs to disabled. Set include-hidden-files to true when uploading code coverage artifacts.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Sep 10, 2024

Test Suite Status Result
Multiverse 7/7 passing
SOAK 54/56 passing

@lavarou lavarou changed the title fix(pr runner): Enable hidden files for agent codecov ci: fix test-pull-request workflow Sep 10, 2024
@zsistla zsistla requested review from lavarou and mfulb September 10, 2024 16:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (263681e) to head (59e35ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         194      194           
  Lines       26880    26880           
=======================================
  Hits        21055    21055           
  Misses       5825     5825           
Flag Coverage Δ
agent-for-php-7.2 78.33% <ø> (ø)
agent-for-php-7.3 78.35% <ø> (ø)
agent-for-php-7.4 78.06% <ø> (ø)
agent-for-php-8.0 78.08% <ø> (ø)
agent-for-php-8.1 78.07% <ø> (ø)
agent-for-php-8.2 77.67% <ø> (ø)
agent-for-php-8.3 77.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsistla zsistla merged commit 108af43 into main Sep 10, 2024
59 checks passed
@zsistla zsistla deleted the ads/codecov_hidden_files branch September 10, 2024 16:37
@zsistla zsistla restored the ads/codecov_hidden_files branch September 10, 2024 16:49
zsistla added a commit that referenced this pull request Sep 10, 2024
@zsistla zsistla deleted the ads/codecov_hidden_files branch September 10, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants